Skip to content

Py value into ref #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Py value into ref #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion vm/src/pyobject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,8 +1578,29 @@ impl PyObject {

// The intention is for this to replace `PyObjectPayload` once everything is
// converted to use `PyObjectPayload::AnyRustvalue`.
pub trait PyValue: Any + fmt::Debug {
pub trait PyValue: Any + fmt::Debug + Sized {
fn required_type(ctx: &PyContext) -> PyObjectRef;

fn into_ref(self, ctx: &PyContext) -> PyRef<Self> {
PyRef {
obj: PyObject::new(self, Self::required_type(ctx)),
_payload: PhantomData,
}
}

fn into_ref_with_type(self, vm: &mut VirtualMachine, cls: PyClassRef) -> PyResult<PyRef<Self>> {
let required_type = Self::required_type(&vm.ctx);
if objtype::issubclass(&cls.obj, &required_type) {
Ok(PyRef {
obj: PyObject::new(self, cls.obj),
_payload: PhantomData,
})
} else {
let subtype = vm.to_pystr(&cls.obj)?;
let basetype = vm.to_pystr(&required_type)?;
Err(vm.new_type_error(format!("{} is not a subtype of {}", subtype, basetype)))
}
}
}

impl FromPyObjectRef for PyRef<PyClass> {
Expand Down