Skip to content

Selenium tests for WASM #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Selenium tests for WASM #684

merged 3 commits into from
Mar 15, 2019

Conversation

palaviv
Copy link
Contributor

@palaviv palaviv commented Mar 15, 2019

Not many tests but this should validate we don't break WASM.
I tried using PhantomJS as mentioned in #530 but it did not work...

@adrian17
Copy link
Contributor

That seems like a bit of an overkill to me. Wouldn't it possible to load wasm and run tests on Node?

@coolreader18
Copy link
Member

Yes, with wasm-bindgen-test, as I mentioned in #530, you can run tests in Node.

@windelbouwman
Copy link
Contributor

This is very cool! @palaviv nice job!

@windelbouwman windelbouwman merged commit bbe2704 into RustPython:master Mar 15, 2019
@adrian17
Copy link
Contributor

Yes, with wasm-bindgen-test, as I mentioned in #530, you can run tests in Node.

So, why would we need selenium tests, then?

@windelbouwman
Copy link
Contributor

@adrian17 I agree with you that this test is spinning up a lot of different tools, but I think it is a good crosscheck. Can we do the same with wasm-bindgen-test in a lightweigher way, or do we exclude some code when we do that?

@coolreader18
Copy link
Member

coolreader18 commented Mar 15, 2019

wasm-bindgen-test uses the native rust testing framework, e.g. #[test], so we'd have to design our tests around that. Another concern is that as far as I know, there's no way to get code coverage for rust compiled to WASM, which sucks, but if there is some way to do it I'd say we should definitely go with that.

@palaviv
Copy link
Contributor Author

palaviv commented Mar 16, 2019

@adrian17 I am not familiar with wasm-bindgen-test. I wanted to push something to validate the WASM is good in the CI as I almost broke it on a typo in #652. I agree selenium is very complex and if we can do it by using other tools lets do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants