Skip to content

Change PyObject.typ to PyClassRef #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2019
Merged

Change PyObject.typ to PyClassRef #737

merged 3 commits into from
Mar 23, 2019

Conversation

BenLewis-Seequent
Copy link

To do this I replaced a few PyObject::new with PyValue::{into_ref, into_ref_with_type}.

@codecov-io
Copy link

codecov-io commented Mar 23, 2019 •
edited
Loading

Codecov Report

Merging #737 into master will decrease coverage by 1.21%.
The diff coverage is 44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage    45.9%   44.68%   -1.22%     
==========================================
  Files          81       81              
  Lines       16164    16373     +209     
  Branches     3966     4099     +133     
==========================================
- Hits         7420     7317     -103     
- Misses       6945     7268     +323     
+ Partials     1799     1788      -11
Impacted Files Coverage Δ
vm/src/obj/objcode.rs 40.21% <ø> (+8.39%) ⬆️
src/main.rs 11.46% <0%> (-1.87%) ⬇️
vm/src/obj/objmemory.rs 21.73% <0%> (+3.22%) ⬆️
vm/src/obj/objsequence.rs 32.93% <0%> (ø) ⬆️
vm/src/obj/objobject.rs 49% <0%> (-0.4%) ⬇️
wasm/lib/src/browser_module.rs 0% <0%> (ø) ⬆️
vm/src/import.rs 32.83% <0%> (ø) ⬆️
vm/src/obj/objfloat.rs 47.89% <0%> (ø) ⬆️
wasm/lib/src/vm_class.rs 0% <0%> (ø) ⬆️
wasm/lib/src/convert.rs 0% <0%> (ø) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666a09...faf1925. Read the comment docs.

OddCoincidence
OddCoincidence approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@OddCoincidence OddCoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll merge this once the conflict is resolved

@OddCoincidence OddCoincidence merged commit a156010 into RustPython:master Mar 23, 2019
@BenLewis-Seequent BenLewis-Seequent deleted the object_type_pyclassref branch March 29, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OddCoincidence OddCoincidence OddCoincidence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenLewis-Seequent @codecov-io @OddCoincidence @skinnyBat