Introduce Either extractor and convert range.__getitem__ #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 44.69% 44.78% +0.08%
==========================================
Files 81 81
Lines 16390 16379 -11
Branches 4089 4093 +4
==========================================
+ Hits 7326 7335 +9
+ Misses 7275 7258 -17
+ Partials 1789 1786 -3
Continue to review full report at Codecov.
|
coolreader18
approved these changes
Mar 24, 2019
| /// | ||
| /// Note: The returned `Result` is _not_ a `PyResult`, even though the | ||
| /// types are compatible. | ||
| pub fn downcast<T: PyObjectPayload>(self: Rc<Self>) -> Result<PyRef<T>, PyObjectRef> { |
There was a problem hiding this comment.
I thought arbitrary self types hadn't landed yet?
There was a problem hiding this comment.
It hasn't for user-defined types, but Box<Self> and Rc<Self> as self types are allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I intentionally implemented
TryFromObjectonly for anEitherof twoPyRefs rather than any two types than implementTryFromObject. This is because doing the latter would pointlessly allocate an error object whenever the argument was typeB. By restricting this toPyRefs, we can just try to downcast, which is a lot cheaper.Example of the error messages this returns: