Tests cleanups #749
Merged
Tests cleanups #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 42.88% 41.86% -1.03%
==========================================
Files 81 81
Lines 17019 17019
Branches 4244 4244
==========================================
- Hits 7299 7125 -174
- Misses 7953 8139 +186
+ Partials 1767 1755 -12
Continue to review full report at Codecov.
|
| @@ -1,2 +0,0 @@ | |||
| x = [] | |||
There was a problem hiding this comment.
Why did you remove this file? I agree the test makes little sense, but still, it is a valid test.
There was a problem hiding this comment.
Because other tests in list.py do the same job. No point testing the same thing twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Didn't touch cpython_bytecode tests, as they don't seem to be working anyway?)
This massively speeds up time of running all tests, to 5-10 seconds max.