Skip to content

Conversation

OddCoincidence
Copy link
Contributor

  • Rename to class to mirror python __class__
  • Reduce to one variant
  • Remove objtype::get_type_name

@codecov-io
Copy link

Codecov Report

Merging #750 into master will increase coverage by 0.08%.
The diff coverage is 52.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   41.97%   42.06%   +0.08%     
==========================================
  Files          80       80              
  Lines       16925    16866      -59     
  Branches     4223     4217       -6     
==========================================
- Hits         7104     7094      -10     
+ Misses       8074     8026      -48     
+ Partials     1747     1746       -1
Impacted Files Coverage Δ
vm/src/obj/objiter.rs 40.27% <ø> (ø) ⬆️
vm/src/function.rs 29.32% <0%> (ø) ⬆️
vm/src/obj/objfloat.rs 46.93% <0%> (-0.41%) ⬇️
vm/src/exceptions.rs 37.5% <0%> (-0.24%) ⬇️
wasm/lib/src/wasm_builtins.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/json.rs 57.6% <0%> (ø) ⬆️
vm/src/obj/objsuper.rs 37.23% <0%> (ø) ⬆️
vm/src/obj/objfunction.rs 36.92% <100%> (ø) ⬆️
vm/src/obj/objint.rs 65.01% <100%> (+6.41%) ⬆️
vm/src/obj/objproperty.rs 44.02% <100%> (-0.18%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b816f...625d235. Read the comment docs.

@cthulahoops cthulahoops merged commit e68eb9c into master Mar 26, 2019
@OddCoincidence OddCoincidence deleted the joey/cleanup-type-protocol branch April 9, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants