Skip to content

Upgrade lalrpop #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Upgrade lalrpop #754

merged 1 commit into from
Mar 27, 2019

Conversation

adrian17
Copy link
Contributor

@adrian17 adrian17 commented Mar 26, 2019

Seems like removal of lalrpop-snap in the new version will improve build times a tiny little bit.

@coolreader18
Copy link
Member

It looks like lalrpop now outputs to OUT_DIR , so you should remove python.rs from all the gitignores and just put include!(concat!(env!("OUT_DIR"), "/python.rs")) in it.

@adrian17 adrian17 changed the title Upgrade lalrpop WIP: Upgrade lalrpop Mar 26, 2019
@adrian17 adrian17 changed the title WIP: Upgrade lalrpop Upgrade lalrpop Mar 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files          80       80           
  Lines       12739    12739           
  Branches     2651     2651           
=======================================
  Hits         7849     7849           
  Misses       3176     3176           
  Partials     1714     1714
Impacted Files Coverage Δ
parser/src/token.rs 28.57% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cda87a...40dd75d. Read the comment docs.

@windelbouwman windelbouwman merged commit c2eb664 into RustPython:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants