Convert bytes to new args style #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
approved these changes
Mar 28, 2019
coolreader18
approved these changes
Mar 28, 2019
| } | ||
| fn repr(self, _vm: &VirtualMachine) -> String { | ||
| // TODO: don't just unwrap | ||
| let data = String::from_utf8(self.value.clone()).unwrap(); |
There was a problem hiding this comment.
We'd need a UnicodeDecodeError class for this, eventually.
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 61.95% 61.99% +0.04%
==========================================
Files 80 80
Lines 12708 12686 -22
Branches 2606 2607 +1
==========================================
- Hits 7873 7865 -8
+ Misses 3165 3158 -7
+ Partials 1670 1663 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.