Skip to content

Add support for trailing comma in function defs. Parser code simplica… #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2019
Merged

Add support for trailing comma in function defs. Parser code simplica… #760

merged 1 commit into from
Mar 31, 2019

Conversation

windelbouwman
Copy link
Contributor

…tions.

@codecov-io
Copy link

Codecov Report

Merging #760 into master will decrease coverage by 0.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   61.77%   61.76%   -0.02%     
==========================================
  Files          80       80              
  Lines       12683    12690       +7     
  Branches     2607     2609       +2     
==========================================
+ Hits         7835     7838       +3     
- Misses       3170     3172       +2     
- Partials     1678     1680       +2
Impacted Files Coverage Δ
parser/src/lexer.rs 83.62% <70%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149aefe...73cd680. Read the comment docs.

coolreader18
coolreader18 approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not that familiar with the parser. On a side note, how do you write this? Do you have a syntax highlighter for lalrpop? I looked, but I couldn't find one.

@windelbouwman
Copy link
Contributor Author

The LALRPOP syntax is a unique mix of grammar and rust code. I do not have a code editor with syntax highlighting or something. The documentation is on the lalrpop website and the examples of lalrpop.

@windelbouwman windelbouwman merged commit 69c8173 into master Mar 31, 2019
@windelbouwman windelbouwman deleted the parser-fixes branch April 9, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windelbouwman @codecov-io @coolreader18