Skip to content

Refactor slice.__new__ to new style function #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 17, 2019
Merged

Refactor slice.__new__ to new style function #767

merged 6 commits into from
Apr 17, 2019

Conversation

BenLewis-Seequent
Copy link

Also made the following changes:

  • Allowed slice to contain arbitrary objects
  • Implemented calling __index__ if slice property isn't an int

@codecov-io
Copy link

codecov-io commented Mar 30, 2019 •
edited
Loading

Codecov Report

Merging #767 into master will increase coverage by 0.02%.
The diff coverage is 61.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   63.12%   63.14%   +0.02%     
==========================================
  Files          87       87              
  Lines       14344    14374      +30     
  Branches     3248     3257       +9     
==========================================
+ Hits         9055     9077      +22     
- Misses       3154     3162       +8     
  Partials     2135     2135
Impacted Files Coverage Δ
vm/src/obj/objrange.rs 62.22% <0%> (-1.13%) ⬇️
vm/src/obj/objlist.rs 72.21% <0%> (-0.98%) ⬇️
vm/src/obj/objsequence.rs 53.62% <33.33%> (-0.79%) ⬇️
vm/src/obj/objslice.rs 78.66% <72.54%> (+15.92%) ⬆️
vm/src/function.rs 51.21% <75%> (+0.72%) ⬆️
vm/src/frame.rs 67.67% <80%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7275c7...9b71424. Read the comment docs.

OddCoincidence
OddCoincidence reviewed Mar 30, 2019
View reviewed changes
OddCoincidence
OddCoincidence reviewed Mar 31, 2019
View reviewed changes
OddCoincidence
OddCoincidence reviewed Mar 31, 2019
View reviewed changes
@OddCoincidence
Copy link
Contributor

It looks like rustfmt is the only thing failing, after that is fixed we can merge this

@windelbouwman
Copy link
Contributor

@Skinny121 @OddCoincidence could we merge this PR? It looks like all review comments were dealed with?

@skinnyBat
Merge branch 'master' into slice_new
f2873a5 
# Conflicts:
#	tests/snippets/builtin_slice.py
#	vm/src/frame.rs
#	vm/src/obj/objrange.rs
#	vm/src/obj/objslice.rs
@skinnyBat
Use slice.xxx_index() methods in setslice and delslice
9b71424
@windelbouwman windelbouwman merged commit 75e8f81 into RustPython:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@OddCoincidence OddCoincidence OddCoincidence left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenLewis-Seequent @codecov-io @OddCoincidence @windelbouwman @skinnyBat