str: improve {is,}title impl and add tests #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation didn't actually title-case, it just naively capitalized the first letter of each word. Also note that this is still not 100% on-par with cpython because it doesn't handle unicode titlecase characters, e.g. digraphs that consist of an uppercase and a lowercase letter. It looks like rust used to support this on nightly but removed it because they couldn't add corresponding methods on strings without a
unicode-segmentationdependency. I'll see if I can extract that support into its own crate.Also note that I added the tests as rust unit tests; this is getting significantly less painful with recent refactors and I think we should do it more.