Skip to content

RustPython changes for #824 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2019
Merged

RustPython changes for #824 #829

merged 3 commits into from
Apr 14, 2019

Conversation

BenLewis-Seequent
Copy link

Split from #824 as requested. These are the changes to RustPython itself to support importing and running unittest.

The changes are:

  • Ability to do an absolute import of a non-top-level module. i.e. import unittest.case. This isn't implemented properly but is a hack to get importing of those to happen.
  • Add function.call
  • Add io.IOBase.flush
  • Add skeleton _thread module
  • Expose types.MethodType
  • Add fake sys.intern and sys.warnoptions
  • Make classmethod have a dict by default.

@codecov-io
Copy link

Codecov Report

Merging #829 into master will decrease coverage by 0.08%.
The diff coverage is 26%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #829      +/-   ##
=========================================
- Coverage   63.28%   63.2%   -0.09%     
=========================================
  Files          84      85       +1     
  Lines       13929   13955      +26     
  Branches     3088    3089       +1     
=========================================
+ Hits         8815    8820       +5     
- Misses       3108    3127      +19     
- Partials     2006    2008       +2
Impacted Files Coverage Δ
vm/src/obj/objclassmethod.rs 90% <ø> (ø) ⬆️
vm/src/stdlib/thread.rs 0% <0%> (ø)
vm/src/vm.rs 71.06% <0%> (-0.49%) ⬇️
vm/src/stdlib/types.rs 0% <0%> (ø) ⬆️
vm/src/pyobject.rs 80.26% <0%> (ø) ⬆️
vm/src/eval.rs 64.28% <0%> (+8.03%) ⬆️
vm/src/stdlib/mod.rs 100% <100%> (ø) ⬆️
vm/src/obj/objobject.rs 75.81% <20%> (-2.04%) ⬇️
vm/src/obj/objfunction.rs 64.15% <25%> (-3.2%) ⬇️
vm/src/sysmodule.rs 65.45% <40%> (-2.55%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3319e...307689a. Read the comment docs.

cthulahoops
cthulahoops approved these changes Apr 14, 2019
View reviewed changes
Copy link
Collaborator

@cthulahoops cthulahoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from test failure on windows.

@windelbouwman
Copy link
Contributor

Looks good to me too!

@windelbouwman windelbouwman merged commit 51aa817 into RustPython:master Apr 14, 2019
@BenLewis-Seequent BenLewis-Seequent mentioned this pull request Apr 16, 2019
Merged
@sanxiyn sanxiyn mentioned this pull request May 9, 2019
Merged
@palaviv palaviv mentioned this pull request May 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulahoops cthulahoops cthulahoops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenLewis-Seequent @codecov-io @windelbouwman @cthulahoops @skinnyBat