Add nonlocal support. #839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 63.12% 64.04% +0.92%
==========================================
Files 87 87
Lines 14344 14892 +548
Branches 3248 3519 +271
==========================================
+ Hits 9055 9538 +483
- Misses 3154 3213 +59
- Partials 2135 2141 +6
Continue to review full report at Codecov.
|
Yes. I think cell, deref, and nonlocal all refer to roughly the same thing. (A cell stores variables for non-local access, and you deref the cell?) I suggest we rename |
vm/src/frame.rs
Outdated
| .iter() | ||
| .skip(1) | ||
| .next() | ||
| .unwrap() |
There was a problem hiding this comment.
This panic here is an interesting case. It looks like cpython raises SyntaxError is it can't find the relevant variable at compile time. You can't create a variable in an outer scope with nonlocal, only change it. (Unlike global.)
We can't do better than this yet, but worth using .expect("no outer scope for non-local")?
There was a problem hiding this comment.
Allright, good suggestion! A next topic for me would be to detect more errors at compile time, like cpython does, and raise proper syntax errors.
@cthulahoops I'm a bit confused about the load_cell name. Is it the same as the load_deref opcode in cpython?