Skip to content

Fix os.unsetenv test for windows #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix os.unsetenv test for windows #840

merged 2 commits into from
Apr 17, 2019

Conversation

coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Apr 17, 2019 •
edited
Loading

Should we add a cfg to not put unsetenv into os if on Windows?

@coolreader18 coolreader18 changed the title Fix os.unsetenv test for windows Should we add a cfg to not put unsetenv into os if on Windows? Fix os.unsetenv test for windows Apr 17, 2019
@windelbouwman
Copy link
Contributor

It still is a mistery to me why we do not have unsetenv on windows. I think we set the symbol on the os module explicitly (https://github.com/RustPython/RustPython/blob/master/vm/src/stdlib/os.rs#L217).

Anyway, I will merge this fix to repair the windows build.

@windelbouwman windelbouwman merged commit 780ee8a into master Apr 17, 2019
@coolreader18 coolreader18 deleted the coolreader18/fix-unsetenv-test branch April 19, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman Awaiting requested review from windelbouwman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @windelbouwman