Skip to content

Add some benchmark scripts. #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Add some benchmark scripts. #842

merged 1 commit into from
Apr 18, 2019

Conversation

windelbouwman
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   63.16%   63.16%           
=======================================
  Files          87       87           
  Lines       14382    14382           
  Branches     3257     3257           
=======================================
  Hits         9085     9085           
  Misses       3160     3160           
  Partials     2137     2137
Impacted Files Coverage Δ
vm/src/compile.rs 77.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240c1e4...84457e6. Read the comment docs.

@@ -0,0 +1,31 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be something in here to compile RustPython like test_snippets.py does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, I don't know. Maybe also not. I think it is okay if it picks the latest release build.

@windelbouwman windelbouwman merged commit ae7058f into master Apr 18, 2019

@pytest.mark.parametrize('exe', pythons)
@pytest.mark.parametrize('args', benchmarks)
def test_bench(exe, args, benchmark):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this being run on every pytest invocation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not run on travis, but when you run pytest in the benchmark directory, it will run test_bench for each snippet and each interpreter.

@windelbouwman windelbouwman deleted the benchmarking branch April 24, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants