Improve syntax error with line information. #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Apr 17, 2019
|
|
||
| use std::error::Error; | ||
| use std::fmt; | ||
|
|
||
| #[derive(Debug)] | ||
| pub enum CompileError { | ||
| pub struct CompileError { | ||
| pub error: CompileErrorType, |
There was a problem hiding this comment.
Maybe something like problem or issue for naming here instead of error/CompileErrorType?
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
==========================================
- Coverage 63.16% 63.13% -0.04%
==========================================
Files 87 87
Lines 14381 14414 +33
Branches 3255 3257 +2
==========================================
+ Hits 9084 9100 +16
- Misses 3162 3176 +14
- Partials 2135 2138 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.