Skip to content

Add benches #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Add benches #846

merged 1 commit into from
Apr 19, 2019

Conversation

LuoZijun
Copy link
Contributor

Resolve #830

@LuoZijun
Copy link
Contributor Author

LuoZijun commented Apr 18, 2019

OS: macOS High Sierra 10.13.5 (17F77)
Laptop: MacBook Pro (Retina, 15-inch, Mid 2015)
Hardware: Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz

$ cargo bench

     Running target/release/deps/parser-9219a509bec6327a

running 2 tests
test bench_parse_to_ast ... bench:  60,803,145 ns/iter (+/- 4,723,694) = 1 MB/s
test bench_tokenization ... bench:  49,881,125 ns/iter (+/- 2,945,707) = 1 MB/s

test result: ok. 0 passed; 0 failed; 0 ignored; 2 measured; 0 filtered out

     Running target/release/deps/vm-8dc2abb21006a2be

running 2 tests
test bench_mandelbrot ... bench: 6,220,665,421 ns/iter (+/- 551,599,249)
test bench_nbody      ... bench: 2,435,969,675 ns/iter (+/- 53,865,485)

@LuoZijun LuoZijun mentioned this pull request Apr 18, 2019
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   62.99%   62.99%           
=======================================
  Files          88       88           
  Lines       14547    14547           
  Branches     3288     3288           
=======================================
  Hits         9164     9164           
  Misses       3222     3222           
  Partials     2161     2161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148ef5c...7822f6d. Read the comment docs.

@windelbouwman
Copy link
Contributor

@LuoZijun
Copy link
Contributor Author

@windelbouwman

Yeah, i know that folder. if you decided to use Python to write benchmark, So how do we write some internal benchmarks? e.g lexer, parser.

@windelbouwman
Copy link
Contributor

Okay, that is good. Could you move the benchmarks into the benchmarking folder so that we do not duplicate the nbody.py and mandelbrot.py files? Also, we would have a single benchmarking directory with multiple types of benchmarks.

@LuoZijun
Copy link
Contributor Author

@windelbouwman

I turned off the stdout of nbody.py and mandelbrot.py files.
because they were not necessary for a benchmark.

@LuoZijun LuoZijun force-pushed the add-benches branch 3 times, most recently from 80de542 to b63519a Compare April 19, 2019 16:23
@windelbouwman windelbouwman merged commit 52a1a95 into RustPython:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance
4 participants