Use temp directory for os test #849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 62.89% 62.99% +0.09%
==========================================
Files 88 88
Lines 14547 14547
Branches 3288 3288
==========================================
+ Hits 9150 9164 +14
+ Misses 3238 3222 -16
- Partials 2159 2161 +2
Continue to review full report at Codecov.
|
tests/snippets/stdlib_os.py
Outdated
| base_folder = os.environ["TEMP"] | ||
| else: | ||
| base_folder = "/tmp" | ||
| name = base_folder + os.sep + "test_os" |
There was a problem hiding this comment.
Could we prefix "test_os" so that if the test failed and someone's cleaning out their temp folder, they could know what it was for? Maybe "rustpython_test_os"?
tests/snippets/stdlib_os.py
Outdated
| for f in os.listdir(self.name): | ||
| # Currently don't support dir delete. | ||
| os.remove(self.name + os.sep + f) | ||
| os.rmdir(self.name) |
There was a problem hiding this comment.
It looks like this is what's causing CI to fail, I think this SO answer has a good solution for it with what modules we have right now.
There was a problem hiding this comment.
I changed it to not delete the folder. This fails only on rustpython and not in Cpython so I will try to solve this at a later stage. The test folder is in temp and very small so that should not be a problem.
|
Great. חג שמח 😃 |
This should allow us to extend filesystem tests.