Add os.scandir #852
Merged
Add os.scandir #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 63.14% 63.15% +<.01%
==========================================
Files 88 88
Lines 14591 14646 +55
Branches 3265 3276 +11
==========================================
+ Hits 9214 9250 +36
- Misses 3239 3247 +8
- Partials 2138 2149 +11
Continue to review full report at Codecov.
|
| @@ -73,3 +75,26 @@ def __exit__(self, exc_type, exc_val, exc_tb): | |||
| assert os.read(fd, len(CONTENT2)) == CONTENT2 | |||
| assert os.read(fd, len(CONTENT3)) == CONTENT3 | |||
| os.close(fd) | |||
|
|
|||
| fname2 = tmpdir + os.sep + FILE_NAME2 | |||
There was a problem hiding this comment.
We are in need of os.path.join :).
There was a problem hiding this comment.
It's all python code in path. I will look if it can be copied as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently support
name, path, is_dir, is_file.I will add
statandsymlinksupport in separate PRs.