Skip to content

Implement deleting tuples #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2019
Merged

Implement deleting tuples #854

merged 2 commits into from
Apr 21, 2019

Conversation

sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Apr 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 21, 2019 •
edited
Loading

Codecov Report

Merging #854 into master will increase coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage   63.14%   63.15%   +0.01%     
==========================================
  Files          88       88              
  Lines       14591    14614      +23     
  Branches     3265     3272       +7     
==========================================
+ Hits         9214     9230      +16     
  Misses       3239     3239              
- Partials     2138     2145       +7
Impacted Files Coverage Δ
vm/src/compile.rs 77.13% <54.54%> (-0.14%) ⬇️
vm/src/obj/objset.rs 71.47% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afb5d3...2aeb0ad. Read the comment docs.

coolreader18
coolreader18 approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing! One little thing that it would be great if you could change, and then I'll merge.

@coolreader18 coolreader18 merged commit d55d884 into RustPython:master Apr 21, 2019
@sanxiyn sanxiyn deleted the delete-tuple branch April 21, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanxiyn @codecov-io @coolreader18