Add sys.getfilesystemencoding, sys.getfilesystemencodeerrors #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
=========================================
+ Coverage 64.98% 65% +0.01%
=========================================
Files 96 96
Lines 16755 16763 +8
Branches 3734 3734
=========================================
+ Hits 10888 10896 +8
Misses 3348 3348
Partials 2519 2519
Continue to review full report at Codecov.
|
3c368c7 to
9df7ba0
Compare
|
@youknowone this change looks okay to me I guess, do we really need this? Is this cpython specific logic? In any case, if you could resolve the conflict, I could merge this work. |
9df7ba0 to
3675ce8
Compare
|
Fixed. The behavior can be changed but the functions are defined in pep-529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related features:
os.fsencode()os.fsdecode()(with this PR + #901)