Skip to content

Add st_{a,m,c}time to os.stat #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2019

Conversation

BenLewis-Seequent
Copy link

For #958.

@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #962 into master will increase coverage by 0.2%.
The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #962     +/-   ##
=========================================
+ Coverage   64.78%   64.98%   +0.2%     
=========================================
  Files          89       90      +1     
  Lines       15994    16100    +106     
  Branches     3623     3639     +16     
=========================================
+ Hits        10361    10462    +101     
+ Misses       3239     3227     -12     
- Partials     2394     2411     +17
Impacted Files Coverage Δ
vm/src/stdlib/os.rs 71.06% <81.48%> (+2.26%) ⬆️
vm/src/stdlib/mod.rs 100% <0%> (ø) ⬆️
vm/src/stdlib/binascii.rs 77.27% <0%> (ø)
vm/src/sysmodule.rs 66.66% <0%> (+1.21%) ⬆️
vm/src/obj/objstr.rs 76.97% <0%> (+1.37%) ⬆️
vm/src/stdlib/time_module.rs 84.61% <0%> (+30.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a683f2...645c6de. Read the comment docs.

Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just had a few comments about the tests

@BenLewis-Seequent
Copy link
Author

I also implemented os.fsync to assist with testing, the updating of the file time attributes.

@windelbouwman windelbouwman merged commit 0a1399a into RustPython:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants