Move os.fspath to _os #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 64.87% 64.89% +0.01%
==========================================
Files 90 90
Lines 16046 16055 +9
Branches 3634 3636 +2
==========================================
+ Hits 10410 10419 +9
Misses 3231 3231
Partials 2405 2405
Continue to review full report at Codecov.
|
youknowone
reviewed
May 11, 2019
| @@ -133,34 +133,3 @@ def getenv(key, default=None): | |||
| The optional second argument can specify an alternate default. | |||
| key, default and the result are str.""" | |||
| return environ.get(key, default) | |||
|
|
|||
|
|
|||
| def fspath(path): | |||
There was a problem hiding this comment.
Will keeping this funciton as _fspath just as cpython help to test new os_fspath works correctly?
Probably we can test 2 functions return same value.
There was a problem hiding this comment.
We are testing against CPython function
|
@palaviv I tried to merge master into your branch and I messed it up; would you mind adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #958.