Codecov Report

Merging #968 into master will decrease coverage by 0.03%.
The diff coverage is 87.36%.

@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
- Coverage    64.7%   64.67%   -0.04%     
==========================================
  Files          97       97              
  Lines       17041    17032       -9     
  Branches     3799     3802       +3     
==========================================
- Hits        11026    11015      -11     
- Misses       3441     3442       +1     
- Partials     2574     2575       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b968e9...aa6b155. Read the comment docs.

The walrus operator is 3.8 only? Are we targetting that? I tend to feel like we should target 3.7 rather chasing the latest shiny version. (I may be biased because the walrus operator feels like a mistake for the language.)

The lexer refactor is great. It would be nice to split the refactor and feature into separate commits.

Should we merge this now? @cthulahoops would you be good with that? It's been 20 days since this was opened and we should merge before there are conflicts.

I will remove the walrus operator from this change to split the refactor and the walrus operator, so I would rather wait for this.

@cthulahoops could you re-review?

Excuse me, I don't understand, why Python actually needs "walrus operator". Why don't they implement assignment as binary operator?

Excuse me, I don't understand, why Python actually needs "walrus operator". Why don't they implement assignment as binary operator?

To avoid the confusion between == and = which is a common error in other languages. ie.

if x = 5:
   ...

I always thought the lack of an assignment operator was a strength of python. The walrus operator seems like an odd thing to introduce. It'll save a couple of lines of code in its few legitimate uses, but it'll get lots of use where it sholudn't.