Simplify PyFuncArgs get_kwarg/get_optional_kwarg with cloned() #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Some(kwarg_value.clone()); | ||
| } | ||
| None | ||
| self.kwargs.get(key).cloned() |
There was a problem hiding this comment.
Clean code for the win!
windelbouwman
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 64.85% 64.85% -0.01%
==========================================
Files 93 93
Lines 16668 16666 -2
Branches 3776 3774 -2
==========================================
- Hits 10810 10808 -2
Misses 3351 3351
Partials 2507 2507
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing review comment from here #993