Skip to content

✨ Add help menu and ability to run specific tests for validatecodeonce #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 19, 2022
Merged

✨ Add help menu and ability to run specific tests for validatecodeonce #358

merged 9 commits into from
Jul 19, 2022

Conversation

estellajaysong
Copy link
Contributor

@estellajaysong estellajaysong commented Jun 30, 2022 •
edited
Loading

  • Add help menu to validatecodeonce when you use the flag -h

Screen Shot 2022-06-29 at 7 20 44 PM

- Add ability to select specific tests when you use the flag -k

@estellajaysong estellajaysong requested a review from hillairet June 30, 2022 02:52
@estellajaysong estellajaysong self-assigned this Jun 30, 2022
@estellajaysong estellajaysong changed the title Add help menu and ability to run specific tests for validatecodeonce ✨ Add help menu and ability to run specific tests for validatecodeonce Jun 30, 2022
@estellajaysong estellajaysong changed the title ✨ Add help menu and ability to run specific tests for validatecodeonce ✨ Add help menu and ability to run specific tests for validatecodeonce Jun 30, 2022
hillairet
hillairet requested changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@hillairet hillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great.
Documentation is needed though!

@estellajaysong
Copy link
Contributor Author

@hillairet Oh, right! This repo is well documented & looks good! :)

@estellajaysong estellajaysong requested a review from hillairet July 5, 2022 23:36
hillairet
hillairet requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@hillairet hillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example goes a long way. That would give me confidence that I know how to run it without running it.

@estellajaysong estellajaysong requested a review from hillairet July 19, 2022 01:21
@estellajaysong estellajaysong merged commit 0b1c778 into main Jul 19, 2022
@estellajaysong estellajaysong deleted the feature/run_specific_tests branch July 19, 2022 18:11
@estellajaysong estellajaysong restored the feature/run_specific_tests branch July 19, 2022 18:11
@estellajaysong estellajaysong deleted the feature/run_specific_tests branch July 19, 2022 18:11
@estellajaysong estellajaysong restored the feature/run_specific_tests branch July 21, 2022 19:51
@estellajaysong estellajaysong deleted the feature/run_specific_tests branch July 21, 2022 19:51
@estellajaysong estellajaysong restored the feature/run_specific_tests branch July 21, 2022 20:42
@estellajaysong estellajaysong deleted the feature/run_specific_tests branch July 21, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hillairet hillairet hillairet approved these changes

@rahulpatidar0191 rahulpatidar0191 rahulpatidar0191 approved these changes

Assignees

@estellajaysong estellajaysong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estellajaysong @hillairet @rahulpatidar0191