Skip to content

Rebuild content #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 29, 2020
Merged

Rebuild content #197

merged 14 commits into from
Jun 29, 2020

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@christopher-dG
Copy link
Contributor

Looks like a couple of latex-related failures, I'll retry them with texlive-full tomorrow.

@christopher-dG
Copy link
Contributor

!rebuild models/04-diffeqbio_II_networkproperties.jmd

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

Same error even with texlive-full.

@ChrisRackauckas
Copy link
Member

Must be a Weave issue.

@ChrisRackauckas
Copy link
Member

If the PDF fails, does the full build not upload?

@christopher-dG
Copy link
Contributor

Correct. We could do something like julia -e '...' || true to ignore failures but that seems bad. Maybe the weave_file function could catch errors and warn instead of erroring?

@ChrisRackauckas
Copy link
Member

Maybe we just shouldn't weave the PDFs since the markdown files probably are more useful

@christopher-dG
Copy link
Contributor

Seeing as failure seems pretty rare, maybe we ought to just put the pdf part in a try/catch?

@ChrisRackauckas
Copy link
Member

Yeah we can do that too

@christopher-dG
Copy link
Contributor

!rebuild models/04-diffeqbio_II_networkproperties.jmd

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

!rebuild models/04b-diffeqbio_III_steadystates.jmd

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

Would be nice to be able to do multiple individual files like !rebuild models/first.jmd models/second.jmd

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 24, 2020

Looks like that last job removed all the output from the notebook (-6000 lines)

https://github.com/SciML/DiffEqTutorials.jl/blob/rebuild/b4b24f65/notebook/models/04-diffeqbio_II_networkproperties.ipynb

edit: but the notebook for models/04b-diffeqbio_III_steadystates.jmd turned out fine

@ChrisRackauckas
Copy link
Member

The notebooks don't really need the output

@ChrisRackauckas
Copy link
Member

Is there a reason why we only get one .md?

@christopher-dG
Copy link
Contributor

Hm, that's interesting. But there's only one file in https://github.com/SciML/DiffEqTutorials.jl/tree/master/markdown/models not including one for the now-moved pendulum tutorial so it seems like a preexisting issue.

@ChrisRackauckas
Copy link
Member

The markdown files are new so the only ones that exist are ones that I manually created about three months ago or something like that, but one of the things I hope to happen is that they all get generated in this new round of generation.

@christopher-dG
Copy link
Contributor

Ah, I see. And now that I think of it, I know why they're not being pushed -- it only stages updated files, not new (and hence untracked) files to avoid committing junk. I think maybe we can just stage everything and tweak the gitignore as necessary.

@christopher-dG
Copy link
Contributor

!rebuild models

this should include new files now

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

Hahahahahahahaha yikes. The CI setup puts the Julia depot in the current directory to facilitate caching. I can work around that though.

@christopher-dG
Copy link
Contributor

Waiting on JuliaGPU/gitlab-ci#20 and then I can address JuliaGPU/gitlab-ci#25 which will make it okay to stage all files.

@christopher-dG
Copy link
Contributor

!rebuild models

ok let's see if i fixed that properly

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

!rebuild models

we're almost there

@christopher-dG
Copy link
Contributor

!rebuild models

oops

@github-actions
Copy link
Contributor Author

Created pipeline: see it here.

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 29, 2020

08-kolmogorov_equations.jmd has some errors https://gitlab.com/JuliaGPU/DiffEqTutorials.jl/-/jobs/616218638#L3325

@christopher-dG
Copy link
Contributor

All jobs except for 08 are successful, that one exposed a small bug that I've fixed -- and the tutorial itself seems to have some bugs.
Maybe we can merge this now and rebuild 08 separately.

@ChrisRackauckas
Copy link
Member

Yeah, 08 we never fully tested it (@ashutosh-b-b)

@ChrisRackauckas ChrisRackauckas merged commit b611d1e into master Jun 29, 2020
@ChrisRackauckas ChrisRackauckas deleted the rebuild/b4b24f65 branch June 29, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants