You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Add trigger param overProvisionRatio (float64) to add the ability to scale more than the queue request (called over-provisioned). Since this comes from a request #3453, plus 3 votes. Moreover, I believe this helps in autoscaling Deployment, scale Nodes based on request queue with a buffer (warm standby Nodes are available for a while, since process of a Node container from start up, get ready, registered to Hub, and pick up session would take time, a buffer for peak loads period would be an approach that users are prefer).
For example, if there are 20 requests for the browser instead of scaling to 20 Nodes, it is able to scale 20% more than the requested, in this case is 24.
With the above example, the trigger param overProvisionRatio is set to 0.2 (representing 20% percentage more than base request)
The trigger param only accepts values greater than 0. Otherwise, it will not take effect.
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Add overProvisionRatio parameter to Selenium Grid KEDA scaler
Enable scaling beyond queue request count for better resource provisioning
Update metadata structure with float64 types for scaling parameters
Update KEDA image tags to latest version (20250721)
Diagram Walkthrough
flowchart LR
A["Queue Requests"] --> B["getScaledCount()"]
B --> C["Apply overProvisionRatio"]
C --> D["Scaled Metric Value"]
D --> E["KEDA Scaling Decision"]
Loading
File Walkthrough
Relevant files
Enhancement
selenium_grid_scaler.go
Add over-provision ratio scaling logic
.keda/scalers/selenium_grid_scaler.go
Add OverProvisionRatio field to metadata struct
Change TargetValue and ActivationThreshold from int64 to float64
Implement getScaledCount() function to apply over-provision ratio
Update metric generation to use scaled count with ratio
The over-provision ratio is only applied when greater than 1, but this prevents using ratios between 0 and 1 for under-provisioning scenarios. The condition should allow any positive ratio or have clear documentation about the intended behavior.
ifoverProvisionRatio>1 {
// Apply over-provision ratio to the scaled countscaledCount*=overProvisionRatio
}
returnscaledCount
Changing TargetValue and ActivationThreshold from int64 to float64 is a breaking change that could affect existing configurations. The migration path and backward compatibility should be considered.
The overProvisionRatio parameter lacks validation for negative values or extremely large values that could cause unexpected scaling behavior. Input validation should be added to prevent invalid configurations.
Why: The suggestion correctly identifies a misleading error message that was introduced in the PR, improving clarity and making debugging easier.
Medium
Validate over-provision ratio bounds
The function should validate that overProvisionRatio is not negative or zero to prevent unexpected scaling behavior. Add a check to ensure the ratio is positive before applying it.
func getScaledCount(newRequestNodes int64, onGoingSession int64, overProvisionRatio float64) float64 {
scaledCount := float64(newRequestNodes + onGoingSession)
if overProvisionRatio > 1 {
// Apply over-provision ratio to the scaled count
scaledCount *= overProvisionRatio
+ } else if overProvisionRatio > 0 && overProvisionRatio <= 1 {+ // For ratios between 0 and 1, still apply the ratio+ scaledCount *= overProvisionRatio
}
+ // If overProvisionRatio <= 0, return original scaledCount
return scaledCount
}
Apply / Chat
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies that overProvisionRatio should be handled for values other than > 1, improving robustness by preventing negative or zero ratios from causing unexpected scaling.
VietND96
changed the title
[KEDA] Selenium Grid: Add trigger param overProvisionRatio for ability to scale more than queue request
[KEDA] Selenium Grid: Add trigger param overProvisionRatio for ability to scale more than queue request
Jul 23, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Feature preview of kedacore/keda#6920
Add trigger param
overProvisionRatio(float64) to add the ability to scale more than the queue request (called over-provisioned). Since this comes from a request #3453, plus 3 votes. Moreover, I believe this helps in autoscaling Deployment, scale Nodes based on request queue with a buffer (warm standby Nodes are available for a while, since process of a Node container from start up, get ready, registered to Hub, and pick up session would take time, a buffer for peak loads period would be an approach that users are prefer).overProvisionRatiois set to0.2(representing 20% percentage more than base request)Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add
overProvisionRatioparameter to Selenium Grid KEDA scalerEnable scaling beyond queue request count for better resource provisioning
Update metadata structure with float64 types for scaling parameters
Update KEDA image tags to latest version (20250721)
Diagram Walkthrough
File Walkthrough
selenium_grid_scaler.go
Add over-provision ratio scaling logic.keda/scalers/selenium_grid_scaler.go
OverProvisionRatiofield to metadata structTargetValueandActivationThresholdfrom int64 to float64getScaledCount()function to apply over-provision ratioselenium_grid_scaler_test.go
Update tests for over-provision ratio.keda/scalers/selenium_grid_scaler_test.go
overProvisionRatioparameter to test argumentsTargetValuefrom expected metadataREADME.md
Update KEDA image tags and documentation.keda/README.md
CONFIGURATION.md
Add KEDA image configuration documentationcharts/selenium-grid/CONFIGURATION.md
keda.imageconfiguration objectMakefile
Update KEDA build configurationMakefile
KEDA_BASED_TAGfrom 20250705 to 20250721TEST_PATCHED_KEDAfrom false to truevalues.yaml
Update KEDA image defaults in Helm chartcharts/selenium-grid/values.yaml