-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[rb][BiDi] Add support for provide response command #15080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb][BiDi] Add support for provide response command #15080
Conversation
…o add_support_for_provide_response_command
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…_command' into add_support_for_provide_response_command
…_command' into add_support_for_provide_response_command
* Add response handler * Update auth handlers and improve the :on method * Request and response working as expected * Add test for continue without auth and cancel auth * Finish implementation * Correct rubocop offenses * Add alias for user to do network.bidi instead of network.network * Fix rust file causing formatting error * Handle requests and responses in block * Add ability to pass handlers to each different intercepted element * Headers working * All tests passing and signatures simplified * remove unnecessary changes * remove unnecessary changes * Added credentials and set cookie header to intercepted response * Fix rubocop issues * Make auth handler more user friendly * Add filtering an url pattern support * Fix formatting issues * Modify tests to avoid element related failures on firefox * Fix styling of comments * Improve types and hash consistency * Update all the places that use 9.4.8.0 * Serialize request values * Refactor cookies, headers and set cookie headers * Simplify serialization * Add extra type support * remove unnecessary comment * Improve typing * add provide response support * Correct rubocop offenses * Remove set cookie headers * Remove set cookie headers * Fix failing tests * Add negative scenario --------- Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
* Add response handler * Update auth handlers and improve the :on method * Request and response working as expected * Add test for continue without auth and cancel auth * Finish implementation * Correct rubocop offenses * Add alias for user to do network.bidi instead of network.network * Fix rust file causing formatting error * Handle requests and responses in block * Add ability to pass handlers to each different intercepted element * Headers working * All tests passing and signatures simplified * remove unnecessary changes * remove unnecessary changes * Added credentials and set cookie header to intercepted response * Fix rubocop issues * Make auth handler more user friendly * Add filtering an url pattern support * Fix formatting issues * Modify tests to avoid element related failures on firefox * Fix styling of comments * Improve types and hash consistency * Update all the places that use 9.4.8.0 * Serialize request values * Refactor cookies, headers and set cookie headers * Simplify serialization * Add extra type support * remove unnecessary comment * Improve typing * add provide response support * Correct rubocop offenses * Remove set cookie headers * Remove set cookie headers * Fix failing tests * Add negative scenario --------- Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
User description
Description
This PR adds support for the provide response method and allows the provide_response method to be passed to response
network.provide_response:
Motivation and Context
This PR continues the work done on #14900 to add full access to all the BiDi network commands
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Introduced BiDi network interception capabilities for requests and responses.
Added support for authentication handling, including skipping, canceling, and providing credentials.
Implemented serialization for cookies, headers, and set-cookie headers.
Enhanced test coverage for BiDi network features and added unit tests for new components.
Changes walkthrough 📝
14 files
Added autoload for new BiDi network interception classes
Enhanced BiDi network with interception and response handling
Added cookie serialization support for BiDi network
Added credentials handling for BiDi network authentication
Added header serialization support for BiDi network
Added intercepted authentication handling for BiDi network
Introduced base class for intercepted network items
Added intercepted request handling for BiDi network
Added intercepted response handling for BiDi network
Added set-cookie header serialization for BiDi network
Added URL pattern formatting for BiDi network interception
Integrated BiDi network interception into common network module
Updated BiDi type signatures for new capabilities
Added type signatures for BiDi network interception methods
6 files
Added integration tests for BiDi network interception
Enhanced integration tests for network handlers
Added unit tests for cookie serialization
Added unit tests for credentials handling
Added unit tests for header serialization
Added unit tests for set-cookie header serialization
11 files