[py] Adjust xfail markers for window size/position tests #15638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR adds some
xfailmarkers and removes somexfailmarkers on Python tests to reflect the state of window sizing and positioning in current browser versions.Window positioning is broken for Firefox on Linux, so we are getting failures in CI. This has been reported to Mozilla.
Edge still has some known issues with window sizing and positioning, so those are now marked.
Chrome has fixed some window positioning issues, so markers were removed.
(This hopefully makes CI green again)
PR Type
Bug fix, Tests
Description
Adjusted
xfailmarkers for window size/position tests.Added
xfailmarkers for Firefox and Edge due to known issues.Removed outdated
xfailmarkers for Chrome.Updated test annotations to reflect current browser behavior.
Changes walkthrough 📝
api_example_tests.py
Adjust `xfail` markers for `test_move_window_position`py/test/selenium/webdriver/common/api_example_tests.py
xfailmarker from Chrome to Edge fortest_move_window_position.xfailmarker for Firefox with a specific issue reference.window_tests.py
Update `xfail` markers for window-related testspy/test/selenium/webdriver/common/window_tests.py
xfailmarkers for Edge and Firefox for multiple tests.xfailmarkers for Chrome.