[dotnet] [bidi] Declare allowed nullable objects in constructors type #15809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
Fixes #15561
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Make DTO constructor parameters nullable where allowed by spec
Update BiDi event and data records to accept null values
Add missing properties to network request data records
Improve type safety for optional BiDi fields
Changes walkthrough 📝
11 files
Make Children and OriginalOpener parameters nullable inBrowsingContextInfoAllow Navigation parameter to be nullable in NavigateResultMake Navigation parameter nullable in NavigationInfoAllow Text parameter to be nullable in all LogEntry recordsMake Context and Navigation parameters nullable inAuthRequiredEventArgsMake Context and Navigation parameters nullable inBaseParametersEventArgsMake Context and Navigation parameters nullable inBeforeRequestSentEventArgsMake Context and Navigation parameters nullable in FetchErrorEventArgsAdd Destination and InitiatorType, make HeadersSize nullable inRequestDataMake Context and Navigation parameters nullable inResponseCompletedEventArgsMake Context and Navigation parameters nullable inResponseStartedEventArgs