Change flag for Chrome/Edge headless mode in tests #15831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR changes the flag for setting headless mode in Chrome/Edge from
--headless=newto--headlessin places where it was used in internal tests.Since Chrome 132, "new" headless mode is the default and
--headless=newwill eventually be removed.We should probably update the docs to mention this. Specifically:
🔄 Types of changes
PR Type
Tests
Description
Update headless flag to
--headlessfor Chrome/Edge testsRemove deprecated
--headless=newusage in test codeEnsure compatibility with Chrome 132+ headless mode changes
Changes walkthrough 📝
EdgeDriverFunctionalTest.java
Update Edge headless flag in functional testjava/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java
--headless=newto--headlessin test.
Browser.java
Update headless flag for Chrome/Edge in driver optionsjava/test/org/openqa/selenium/testing/drivers/Browser.java
--headless=newto--headless.conftest.py
Use `--headless` for Chrome/Edge in Python test configpy/conftest.py
--headless=newto--headlessin test setup.