Skip to content

[py] Fix another broken test #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Jun 5, 2025

User description

🔗 Related Issues

Fix 2 tests broken by #15862

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix, Tests


Description

  • Fixes incorrect regex in test exception matching patterns

  • Updates tests to match new error URL formats


Changes walkthrough 📝

Relevant files
Tests
driver_element_finding_tests.py
Update regex for InvalidSelectorException in test               

py/test/selenium/webdriver/common/driver_element_finding_tests.py

  • Corrects regex for InvalidSelectorException error URL in test
  • Ensures test matches updated error URL format
  • +1/-1     
    stale_reference_tests.py
    Update regex for StaleElementReferenceException in test   

    py/test/selenium/webdriver/common/stale_reference_tests.py

  • Updates regex for StaleElementReferenceException error URL in test
  • Aligns test with new error URL format
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @cgoldberg cgoldberg merged commit a2dc04a into SeleniumHQ:trunk Jun 5, 2025
    4 of 5 checks passed
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @cgoldberg cgoldberg deleted the py-fix-tests branch June 5, 2025 15:52
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @selenium-ci selenium-ci added the C-py Python Bindings label Jun 5, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants