Skip to content

[java]: disable canGetAllCookies test for edge #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

navin772
Copy link
Member

@navin772 navin772 commented Jun 19, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Disables the test canGetAllCookies for Edge due to recent CI failures.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Tests


Description

• Disable canGetAllCookies test for Edge browser
• Add @NotYetImplemented(EDGE) annotation to skip failing test
• Address CI failures in Edge browser testing


Changes walkthrough 📝

Relevant files
Tests
StorageCommandsTest.java
Skip Edge test for cookie retrieval                                           

java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java

• Added @NotYetImplemented(EDGE) annotation to canGetAllCookies test
method
• Prevents test execution on Edge browser to avoid CI failures

+1/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added C-java Java Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Jun 19, 2025
    @navin772 navin772 requested a review from diemol June 19, 2025 14:50
    @navin772 navin772 marked this pull request as ready for review June 19, 2025 14:50
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    5678 - Not compliant

    Non-compliant requirements:

    • Fix ChromeDriver connection failure error that occurs after first instance
    • Address "ConnectFailure (Connection refused)" error for subsequent ChromeDriver instances
    • Ensure proper ChromeDriver instantiation without connection issues

    1234 - Not compliant

    Non-compliant requirements:

    • Fix JavaScript execution in link href on click() for Firefox
    • Ensure click() triggers JavaScript in href attribute
    • Restore functionality that worked in version 2.47.1 but broke in 2.48.0/2.48.2

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 19, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @pujagani pujagani merged commit 56f3075 into SeleniumHQ:trunk Jun 20, 2025
    11 checks passed
    @navin772 navin772 deleted the disable-edge-test branch June 20, 2025 04:23
    @@ -257,6 +257,7 @@ public void canAddAndGetCookie() {
    assertThat(key.getUserContext()).isEqualTo("default");
    }

    @NotYetImplemented(EDGE)
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-devtools Includes everything BiDi or Chrome DevTools related C-java Java Bindings Review effort 1/5
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants