Skip to content

[dotnet] Mark FTP proxy support as deprecated #15925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iampopovich
Copy link
Contributor

@iampopovich iampopovich commented Jun 20, 2025

User description

🔗 Related Issues

Contributes to #15905

💥 What does this PR do?

This pull request adds a deprecation warning to the FtpProxy property in the Proxy.cs file with the single line of code as was requested

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other


Description

  • Mark FTP proxy property as deprecated with obsolete attribute

Changes walkthrough 📝

Relevant files
Deprecation
Proxy.cs
Deprecate FTP proxy property                                                         

dotnet/src/webdriver/Proxy.cs

  • Added [Obsolete] attribute to FtpProxy property with deprecation
    message
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-dotnet .NET Bindings label Jun 20, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Specificity

    The deprecation message specifies removal in version 4.37, but this should be verified against the project's versioning strategy and roadmap to ensure accuracy.

    [Obsolete("FTP proxy support is deprecated and will be removed in the 4.37 version.")]
    public string? FtpProxy

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @nvborisenko nvborisenko left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for your contribution!

    @nvborisenko nvborisenko merged commit 1efb74d into SeleniumHQ:trunk Jun 20, 2025
    13 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants