Skip to content

#993 issue grammar fix #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2022
Merged

#993 issue grammar fix #1089

merged 6 commits into from
Jul 28, 2022

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jul 28, 2022 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

The BiDi page has grammar error in the last paragraph. So fixed it.

Motivation and Context

To make the documentation more readable

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

diemol
diemol requested changes Jul 28, 2022
View reviewed changes
pallavigitwork and others added 2 commits July 28, 2022 15:07
@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit b561092
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62e287494bc246000800eca5
😎 Deploy Preview https://deploy-preview-1089--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

diemol
diemol approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pallavigitwork!

@diemol diemol merged commit 2cd75e7 into SeleniumHQ:trunk Jul 28, 2022
selenium-ci added a commit that referenced this pull request Jul 28, 2022
@selenium-ci
#993 issue grammar fix (#1089)
632137b 
* #993 issue grammar fix

* Update website_and_docs/content/documentation/webdriver/bidirectional/_index.en.md

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

* Update website_and_docs/content/documentation/webdriver/bidirectional/_index.en.md

* Update website_and_docs/content/documentation/webdriver/bidirectional/_index.ja.md

* Update website_and_docs/content/documentation/webdriver/bidirectional/_index.pt-br.md

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

Fixes #993

[deploy site] 2cd75e7
@pallavigitwork
Copy link
Member Author

Thanks @diemol :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pallavigitwork @diemol