Skip to content

adding select by visible text test in example #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 27, 2022
Merged

adding select by visible text test in example #1136

merged 11 commits into from
Aug 27, 2022

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Aug 22, 2022 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

adding select by visible text test java file in example

Motivation and Context

selenium documentation is changing. adding code for select by visible text in example

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Aug 22, 2022 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 0b350b9
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/630a76802e46d90009732819
😎 Deploy Preview https://deploy-preview-1136--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

diemol
diemol reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something missing? I do not see anything special in the changeset.

@pallavigitwork
Copy link
Member Author

changeset

I added a code for select list in the examples folder, for java

@diemol
Copy link
Member

diemol commented Aug 23, 2022

Strange, when I check the changed files on https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1136/files I only see
image

@pallavigitwork
Copy link
Member Author

Strange, when I check the changed files on https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1136/files I only see image

I didn't modify any document. I added code in the example directory of java

diemol
diemol approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pallavigitwork!

@diemol diemol merged commit 66c3cdd into SeleniumHQ:trunk Aug 27, 2022
@pallavigitwork pallavigitwork deleted the example-dropdown branch September 24, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallavigitwork @diemol @harsha509