Skip to content

Conversation

j3soon
Copy link
Contributor

@j3soon j3soon commented Dec 9, 2022

Related: SeleniumHQ/selenium#10261

Description

Add examples for move_to_element_with_offset for Selenium >= 4.3.

Link: https://www.selenium.dev/documentation/webdriver/actions_api/mouse/#move-by-offset

Motivation and Context

Correspond to the fix: SeleniumHQ/selenium#11402

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 4478715
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/63fc7b2108e4dd00084daf95
😎 Deploy Preview https://deploy-preview-1259--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@titusfortner
Copy link
Member

Good catch! I never updated these. Can you also remove the section preceding it since we no longer support offset from upper-left?

@j3soon
Copy link
Contributor Author

j3soon commented Dec 9, 2022

@titusfortner, I removed the preceding section.

@j3soon
Copy link
Contributor Author

j3soon commented Dec 16, 2022

@titusfortner, I see you merged SeleniumHQ/selenium#11402, which fixes the function comments.

However, the documentation is not updated correspondingly, see:

https://www.selenium.dev/documentation/webdriver/actions_api/mouse/#move-by-offset

I wonder why this PR is closed instead of being merged.

Thank you.

@j3soon
Copy link
Contributor Author

j3soon commented Jan 12, 2023

@titusfortner Just pinging this PR, as it's been a month since the last reply.

I'm still wondering why this PR is closed instead of being merged, since the issue is still present.

Thank you.

@titusfortner
Copy link
Member

Hmm, probably I just didn't look closely enough at it. Thanks for the ping.

@titusfortner titusfortner reopened this Jan 12, 2023
@titusfortner titusfortner self-requested a review January 12, 2023 19:09
@j3soon
Copy link
Contributor Author

j3soon commented Jan 27, 2023

Just pinging this PR again, as it's been another 2 weeks since the last reply.

@j3soon
Copy link
Contributor Author

j3soon commented Feb 26, 2023

Just pinging this PR, as it's been 1.5 months since the last reply.

@j3soon
Copy link
Contributor Author

j3soon commented Feb 26, 2023

Just merged the trunk branch into this PR. Ready for merge now. Thanks!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @j3soon!

@diemol diemol merged commit 00120d3 into SeleniumHQ:trunk Feb 27, 2023
@j3soon j3soon deleted the hotfix/10261 branch February 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants