Skip to content

Update dependency selenium-webdriver to v4.20.0 #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/javascript/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"license": "Apache-2.0",
"dependencies": {
"assert": "2.1.0",
"selenium-webdriver": "4.19.0"
"selenium-webdriver": "4.20.0"
},
"devDependencies": {
"mocha": "10.4.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/ruby/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ gem 'rspec', '~> 3.0'
gem 'rubocop', '~> 1.35'
gem 'rubocop-rspec', '~> 2.12'
gem 'selenium-devtools', '= 0.124.0'
gem 'selenium-webdriver', '= 4.19.0'
gem 'selenium-webdriver', '= 4.20.0'
4 changes: 2 additions & 2 deletions examples/ruby/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ GEM
rubyzip (2.3.2)
selenium-devtools (0.124.0)
selenium-webdriver (~> 4.2)
selenium-webdriver (4.19.0)
selenium-webdriver (4.20.0)
base64 (~> 0.2)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
Expand All @@ -78,7 +78,7 @@ DEPENDENCIES
rubocop (~> 1.35)
rubocop-rspec (~> 2.12)
selenium-devtools (= 0.124.0)
selenium-webdriver (= 4.19.0)
selenium-webdriver (= 4.20.0)

BUNDLED WITH
2.5.6
5 changes: 3 additions & 2 deletions examples/ruby/spec/browsers/chrome_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@

def driver_finder
options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
ENV['CHROMEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Chrome::Service)
ENV['CHROME_BIN'] = options.binary
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service)
ENV['CHROMEDRIVER_BIN'] = finder.driver_path
ENV['CHROME_BIN'] = finder.browser_path
end
end
5 changes: 3 additions & 2 deletions examples/ruby/spec/browsers/edge_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@

def driver_finder
options = Selenium::WebDriver::Options.edge(browser_version: 'stable')
ENV['EDGEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Edge::Service)
ENV['EDGE_BIN'] = options.binary
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Edge::Service)
ENV['EDGEDRIVER_BIN'] = finder.driver_path
ENV['EDGE_BIN'] = finder.browser_path
end
end
5 changes: 3 additions & 2 deletions examples/ruby/spec/browsers/firefox_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@

def driver_finder
options = Selenium::WebDriver::Options.firefox(browser_version: 'stable')
ENV['GECKODRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Firefox::Service)
ENV['FIREFOX_BIN'] = options.binary
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Firefox::Service)
ENV['GECKODRIVER_BIN'] = finder.driver_path
ENV['FIREFOX_BIN'] = finder.browser_path
end
end
5 changes: 3 additions & 2 deletions examples/ruby/spec/drivers/service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@

def driver_finder
options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
ENV['CHROMEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Chrome::Service)
ENV['CHROME_BIN'] = options.binary
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service)
ENV['CHROMEDRIVER_BIN'] = finder.driver_path
ENV['CHROME_BIN'] = finder.browser_path
end
end