Skip to content

[deploy site] corrected bug where Other as language appeared #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Aug 1, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

corrected bug where Other as language appeared

Description

corrected bug where Other as language appeared

Motivation and Context

corrected bug where Other as language appeared

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Bug fix


Description

  • Removed "Other" language configuration from Hugo site

  • Commented out unused language section in hugo.toml


Diagram Walkthrough

flowchart LR
  A["hugo.toml config"] -- "comment out" --> B["Other language section"]
  B --> C["Clean language list"]
Loading

File Walkthrough

Relevant files
Bug fix
hugo.toml
Comment out Other language configuration                                 

website_and_docs/hugo.toml

  • Commented out the languages.other configuration section
  • Removed "Other" language from the Hugo site configuration
  • Cleaned up unused language definition and parameters
+6/-6     

Copy link

netlify bot commented Aug 1, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ce61414

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@pallavigitwork pallavigitwork merged commit 4acedae into SeleniumHQ:trunk Aug 1, 2025
1 check passed
@pallavigitwork pallavigitwork deleted the fixLangOther-pal branch August 1, 2025 06:35
@diemol
Copy link
Member

diemol commented Aug 1, 2025

Why don't you remove the section and the pages?

@pallavigitwork
Copy link
Member Author

what section Diego, will it be possible for you to point them to me. I am not aware of where to find them. Kindly let me know, thanks.

@diemol
Copy link
Member

diemol commented Aug 1, 2025

The one you commented out. Also the page https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/website_and_docs/content/_index.other.html

@pallavigitwork
Copy link
Member Author

ok, will look at it and fix, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants