-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add: Adding Http proxies initial document #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harsha509, thanks for this PR!
I apologize for the suggested changes, which basically change your whole proposal for the text, I just saw the opportunity to improve it, focus it on the use case, and went for it. I hope it looks good for you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to request changes, sorry.
Hi @diemol, Please don’t be sorry. I was really hoping to do changes and I didn’t find much better way to explain this. I created PR because I had a strong hunch that you will sure help me in making this doc better. Thanks again for reviewing. Will do the same changes in all translated pages. Regards, |
Performing changes as suggested by @diemol Co-Authored-By: Diego Molina <diemol@users.noreply.github.com>
Still need to do changes for other translated pages. PR not ready ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harsha509!
Updating changes as requested
Updating changes as requested
Updating changes as requested keeping line space 70-80
Updating Line width 70-80 characters
Updating line width with 70-80 characters
Updating line width with 70-80 characters
Updating changes
Updating changes
Updating changes as suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harsha509!
Description
Adding initial document for HTTP PROXIES
Types of changes
Checklist