Skip to content

Add: Adding Http proxies initial document #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 6, 2020
Merged

Add: Adding Http proxies initial document #281

merged 13 commits into from
Mar 6, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Mar 4, 2020

Description

Adding initial document for HTTP PROXIES

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harsha509, thanks for this PR!

I apologize for the suggested changes, which basically change your whole proposal for the text, I just saw the opportunity to improve it, focus it on the use case, and went for it. I hope it looks good for you!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to request changes, sorry.

@harsha509
Copy link
Member Author

I meant to request changes, sorry.

Hi @diemol, Please don’t be sorry. I was really hoping to do changes and I didn’t find much better way to explain this. I created PR because I had a strong hunch that you will sure help me in making this doc better. Thanks again for reviewing.

Will do the same changes in all translated pages.

Regards,
Harsha

Performing changes as suggested by @diemol

Co-Authored-By: Diego Molina <diemol@users.noreply.github.com>
@harsha509
Copy link
Member Author

harsha509 commented Mar 5, 2020

Still need to do changes for other translated pages. PR not ready !

diemol
diemol previously approved these changes Mar 5, 2020
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol diemol dismissed their stale review March 5, 2020 16:11

PR not ready as the OP just said

Updating changes as requested
Updating changes as requested
Updating changes as requested keeping line space 70-80
Updating Line width 70-80 characters
Updating line width with 70-80 characters
Updating line width with 70-80 characters
Updating changes
Updating changes
Updating changes as suggested
@harsha509
Copy link
Member Author

Hi @diemol ,

I think we can close this for now #151. As there is basic/initial content is placed in all docs.

Regards,
Harsha

@harsha509 harsha509 requested a review from diemol March 5, 2020 16:51
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol diemol merged commit c51c2e5 into SeleniumHQ:master Mar 6, 2020
@harsha509 harsha509 deleted the http_proxies branch March 6, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants