Skip to content

Add: Proposing Legacy Capabilities document #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add: Proposing Legacy Capabilities document #351

wants to merge 1 commit into from

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Mar 21, 2020 •
edited
Loading

Description

Proposing Legacy Capabilities document, which speaks about deprecation of desiredCapabilities and requiredCapabilities.

We can also include using of respective [driver]:options with code samples to set capabilities instead of desiredCapabilities

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@harsha509
Copy link
Member Author

Requesting @manoj9788 and @diemol for review!

diemol
diemol reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harsha509,

I like the intention of the PR, which I feel is to illustrate the history and how capabilities have evolved, and show how desired capabilities are being deprecated and so on...

But, if that is really the intention, this PR needs to be more complete, but I am not sure how valuable this content would be for users...

I would find more useful a set of examples with old capabilities code and examples with new capabilities. E.g. this is how it looks in old deprecated caps, and this is how it looks with options. And maybe name the section something like "from desired capabilities to options"?

What do you all think?

@harsha509
Copy link
Member Author

Hi @harsha509,

I like the intention of the PR, which I feel is to illustrate the history and how capabilities have evolved, and show how desired capabilities are being deprecated and so on...

But, if that is really the intention, this PR needs to be more complete, but I am not sure how valuable this content would be for users...

I would find more useful a set of examples with old capabilities code and examples with new capabilities. E.g. this is how it looks in old deprecated caps, and this is how it looks with options. And maybe name the section something like "from desired capabilities to options"?

What do you all think?

HI @diemol ,

Thanks for the review.

As suggested above, placing code samples will complete the document. To keep the document more precise, I will add some more content.

I will work on this offline..!

Thanks,
Harsha

@harsha509 harsha509 closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha509 @diemol