Skip to content

Conversation

kjayachandra2000
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kjayachandra2000 ,

Code looks good to me. I've requested for couple of changes. Can you please look into it.

Regards,
Harsha.

            InternetExplorerOptions options = new InternetExplorerOptions();
            options.ForceCreateProcessApi = true;
            IWebDriver driver = new InternetExplorerDriver(options);
            driver.Url = "https://google.com/ncr";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @kjayachandra2000 ,

Code sample should only explain the initialisation of driver options. i think you can remove the next lines after this step.

Also, can you restrict line spacing to 2 spaces instead of 4. there is lot of free space to the left which we want to use as much as possible.

Same for all code samples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harsha509 ,
I have followed other code snippets for these options, check the link FYI https://www.selenium.dev/documentation/en/driver_idiosyncrasies/driver_specific_capabilities/#ie-command-line-options
But anyways I have done changes as mentioned by you.
image

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kjayachandra2000 !

@harsha509 harsha509 merged commit b38d39a into SeleniumHQ:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants