Skip to content

Conversation

raju249
Copy link
Member

@raju249 raju249 commented Jun 18, 2020

Description

The new section looks as below:

grid4-test

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@raju249
Copy link
Member Author

raju249 commented Jun 18, 2020

Thanks to @manoj9788 for the new image. 🙏

@diemol @harsha509 please take a look. This is the first draft of the new grid 4 section. We can iterate with new stuff in multiple PRs.

Thanks


With Selenium Grid 4,
one server acts as the hub that routes JSON formatted test commands
to one or more registered Grid 4 nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove '4' here. While i read it makes me a bit confusion like Grid for nodes and later i get it as Grid 4 as this document is for Grid 4. As we are already mentioning Selenium Grid 4 in title, Can we simply say Grid nodes/ registered nodes ?

weight: 9
---

# Grid 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Grid 4
# Selenium Grid 4

The hub has a list of registered servers that it provides access to,
and allows control of these instances.

Selenium Grid 4 allows us to run tests in parallel on multiple machines,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Selenium Grid 4 allows us to run tests in parallel on multiple machines,
This feature allows us to run tests in parallel on multiple machines,

weight: 9
---

# Grid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Grid
# Selenium Grid 4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same changes needed for all translated pages

---
title: "Components of a Grid"
weight: 2
---
Copy link
Member

@harsha509 harsha509 Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the components of Grid4 is different from legacy grid ? If not we have introduce Grid 4 with in legacy grid document.

We will end up having duplicate documents for components of grid and purposes and functionalities if there are no changes from previous.

@diemol Can you please suggest on this!

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raju249 ,

Thanks for the PR.

Also very thanks on taking time to translate few pages in respective languages.

I've requested for few changes, can you please look into it.

Regards,
Harsha.

@raju249
Copy link
Member Author

raju249 commented Jun 22, 2020

Thanks @harsha509 for the review.

I have made the other changes, awaiting @diemol's suggestions for your comment

zu übersetzen indem Du uns einen Pull Reqeust schickst!
{{% /notice %}}
{{% /notice %}}
![Grid](/images/grid.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copying the same text from the Grid 3 section. This section should be written again for Grid 4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @diemol yes, I am changing it, I just copied those files. Changing it 👍

@diemol
Copy link
Member

diemol commented Sep 6, 2020

The image is based on the one presented at the Grid workshop done during the Selenium Conference. I will update the original image and add it to this PR.
image

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the image and will merge this. I'll itereate on the content in the next couple of days since I am working on the Grid workshop content.

@diemol diemol dismissed harsha509’s stale review September 6, 2020 22:46

Changes will be done in a next iteration

@diemol diemol merged commit f16b753 into SeleniumHQ:dev Sep 6, 2020
@raju249 raju249 deleted the grid-4-section branch September 7, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants