Skip to content

Python code added under Emulate Geo Location #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2021
Merged

Python code added under Emulate Geo Location #612

merged 3 commits into from
Jan 23, 2021

Conversation

Saketspradhan
Copy link
Contributor

@Saketspradhan Saketspradhan commented Jan 12, 2021 •
edited
Loading

Working fine

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (for Python)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@harsha509 harsha509 added the needs-testing Code needs to be tested locally to get it merged label Jan 12, 2021
baqua10
baqua10 previously approved these changes Jan 13, 2021
View reviewed changes
harsha509
harsha509 requested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Saketspradhan,

Thanks for the PR.
I've requested for couple of changes, can you please look into it.

Also can you add the code sample to other translated pages (like es, zh-cn etc)

@harsha509 harsha509 removed the needs-testing Code needs to be tested locally to get it merged label Jan 20, 2021
@Saketspradhan
Copy link
Contributor Author

Do I have to create separate PRs for every translated page?

@harsha509
Copy link
Member

Do I have to create separate PRs for every translated page?

No Please update the same PR with the code samples in other translated pages!

@harsha509
Copy link
Member

Hi @Saketspradhan,

Did you get a chance to look into above comments?

harsha509
harsha509 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Saketspradhan!

I will add the code sample to other translated pages with another commit referring to this PR.

@harsha509 harsha509 merged commit 320c6b6 into SeleniumHQ:dev Jan 23, 2021
selenium-ci added a commit that referenced this pull request Jan 23, 2021
@selenium-ci
Python code added under Emulate Geo Location (#612)[deploy site]
049c9cb 
* Python code added under Emulate Geo Location

Working fine

* Updated with requested changes

Co-authored-by: JS31096 <12621691+JS31096@users.noreply.github.com> 320c6b6
harsha509 added a commit that referenced this pull request Jan 23, 2021
@harsha509
Add: Adding py code samples for devtools #612 [deploy site]
7aad3e1
selenium-ci added a commit that referenced this pull request Jan 23, 2021
@selenium-ci
Add: Adding py code samples for devtools #612 [deploy site] 7aad3e1
2f0eebc
@harsha509
Copy link
Member

Congratulations on your first PR to Selenium Docs @Saketspradhan 🎉 🎉 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 approved these changes

+1 more reviewer

@baqua10 baqua10 baqua10 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saketspradhan @CLAassistant @harsha509 @baqua10