Adds documentation and examples for relative locator usage. #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for jovial-austin-42fe02 ready! Built with commit aa9d30b https://deploy-preview-636--jovial-austin-42fe02.netlify.app |
diemol
reviewed
Feb 19, 2021
There was a problem hiding this comment.
@AutomatedTester. seems that documentation for relative locators already exists here https://www.selenium.dev/documentation/en/getting_started_with_webdriver/locating_elements/#relative-locators.
Should we merge some of this content of this PR to that page or should we close this PR?
|
I wonder if having it in both places would be good. Since I would expect to find details of locators with its relevant findElement commands. Or at least in my head. Let’s discuss on Monday
…On Feb 19, 2021, 10:23 PM +0000, Diego Molina ***@***.***>, wrote:
@diemol commented on this pull request.
@AutomatedTester. seems that documentation for relative locators already exists here https://www.selenium.dev/documentation/en/getting_started_with_webdriver/locating_elements/#relative-locators.
Should we merge some of this content of this PR to that page or should we close this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
8298fcf to
3cf46cf
Compare
|
@diemol I have moved the documentation as we discussed on Slack this week. Let me know if you want further improvements. |
harsha509
approved these changes
Mar 6, 2021
selenium-ci
added a commit
that referenced
this pull request
Mar 6, 2021
…ploy site] * Adds documentation and examples for relative locator usage. * Remove relative locator for webelement, clean up imports in locating elements document Co-authored-by: Sri Harsha <12621691+JS31096@users.noreply.github.com> 9d05981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds documentation and examples for the new Relative Locators feature in Selenium 4
Motivation and Context
Documentation was missing
Types of changes
Checklist