Skip to content

Conversation

gnatcatcher-bg
Copy link
Contributor

@gnatcatcher-bg gnatcatcher-bg commented Mar 20, 2021

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Translate legacy_docs_index.ko.md into Korean

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 20, 2021

Deploy preview for jovial-austin-42fe02 ready!

Built with commit 049fb1e

https://deploy-preview-649--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gnatcatcher-bg !

@harsha509 harsha509 merged commit dc64ba6 into SeleniumHQ:dev Mar 20, 2021
@harsha509
Copy link
Member

Congratulations on your first contribution to Selenium Docs @gnatcatcher-bg 🥳 🥳 🎉 🎉

@gnatcatcher-bg gnatcatcher-bg deleted the tran-legacy branch March 21, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants