Skip to content

Added CSharp Code in WebElement - GetElement Text #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Added CSharp Code in WebElement - GetElement Text #709

wants to merge 3 commits into from

Conversation

pallavigitwork
Copy link
Member

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

I have added the csharp code for the web element get element text method in all languages

Motivation and Context

The code for Csharp was missing

Types of changes

  • [ x] Change to the site (I am attaching a screenshot showing the before and after)
  • [ x] Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • [ x] I have read the contributing document.
  • [ x] I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pallavigitwork
❌ AgileTestingAlliance
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: ebda943

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/60c353a29130ef000894136f

😎 Browse the preview: https://deploy-preview-709--jovial-austin-42fe02.netlify.app

harsha509
harsha509 requested changes Jun 11, 2021
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AgileTestingAlliance,

Thanks for the PR.

Code samples Look good,

  1. but there are a few extra docs "backup.md" files got added.
  2. There are few extra new lines that got added between code snippetts

Could you please update the pr with above changes

docs_source_files/content/webdriver/web_element.de.md
@@ -534,6 +535,7 @@ Wird verwendet um das Element, das den Fokus hat zu finden oder um es zu verfolg
import org.openqa.selenium.By
import org.openqa.selenium.chrome.ChromeDriver


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AgileTestingAlliance,

I think we don't need an extra black line. Could you please remove the extra blank lines added in the code?

docs_source_files/content/webdriver/web_element.de.md.backup
@@ -0,0 +1,888 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an extra doc. de.md.backup. Can you delete it

docs_source_files/content/webdriver/web_element.en.md
@@ -477,6 +477,8 @@ It is used to track (or) find DOM element which has the focus in the current bro
{{< / code-panel >}}
{{< code-panel language="csharp" >}}
using OpenQA.Selenium;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra new lines. Could you please remove it

@harsha509
Copy link
Member

I think this PR is replaced with a new PR #710.

Closing this as duplicate!

@harsha509 harsha509 closed this Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pallavigitwork @CLAassistant @harsha509 @AgileTestingAlliance