Skip to content

organize element documentation #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Conversation

titusfortner
Copy link
Member

Mostly moving existing content around with a few exceptions. I'm removing Java-specific nomenclature in a lot of parts.

Current Element index File contains:

  1. Finding Element examples
  2. Element Information examples
  • I moved Finding Element examples to new finders.md
  • I moved Element information examples to information.md
  • I added Is Visible and Attributes and Properties placeholder sections to information.md

Current Relative Locators File contains:

  1. Different finding element code examples
  2. Tips for using locators
  3. Traditional locator table
  4. Relative locator examples
  • I renamed the file to just locators.md to focus exclusively on those
  • I merged finding element code into finders.md, and in the process I pretty much completely rewrote it with a better html example
  • I moved the tips into the "Encouraged Test Practices" section and linked to it
  • I updated relative locator examples to only show working with locators (no find element calls, no importing libraries, etc) The goal is going to be to have a full code example somewhere that we can link to, in the meantime this removes extraneous code that isn't what the article is focused on.
  • Added relative locator chaining example

@titusfortner titusfortner requested a review from diemol December 11, 2021 19:53
@netlify
Copy link

netlify bot commented Dec 11, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 9c04e6e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61b73d3022eea9000796ddb7

😎 Browse the preview: https://deploy-preview-876--jovial-austin-42fe02.netlify.app

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @titusfortner!

@diemol diemol merged commit 759fdee into SeleniumHQ:dev Dec 13, 2021
selenium-ci added a commit that referenced this pull request Dec 13, 2021
Co-authored-by: Diego Molina <diemol@users.noreply.github.com> 759fdee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants