Skip to content

Fix: incorrect closing tag in NavMenu Link #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: incorrect closing tag in NavMenu Link #353

wants to merge 1 commit into from

Conversation

abhisingh159
Copy link

WHY are these changes introduced?

Fixes #0000

This PR fixes a JSX syntax issue in the NavMenu component where a <Link> was incorrectly closed using an HTML </a> tag. This results in a rendering bug and violates proper React component structure.

WHAT is this pull request doing?

  • Fixes the closing tag for the second <Link> component in NavMenu
  • Ensures the navigation renders without errors

Before:

<NavMenu>
  <Link to="/" rel="home" />
  <Link to="/pagename">{t("NavigationMenu.pageName")}</a>
</NavMenu>

@abhisingh159 abhisingh159 force-pushed the fix/navmenu-link-closing-tag branch from 419873b to 84da9f7 Compare June 23, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhisingh159